Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

JSONObjectNode#getChildNodes: Cannot read property '...' of null (previousData) #83

Closed
sompylasar opened this issue Aug 23, 2015 · 3 comments
Closed

JSONObjectNode#getChildNodes: Cannot read property '...' of null (previousData) #83

sompylasar opened this issue Aug 23, 2015 · 3 comments
Labels
bug

Comments

@sompylasar
Copy link

First reported by @bkniffler here and by @josebalius here. Just hit this issue, too.

The error happens on this line when clicking a state object node in the devtools to expand it.
@gaearon
Copy link
Contributor

gaearon commented Aug 23, 2015

We're happy to accept a PR, looks like previousData may not be there. If you do a PR, please make similar adjustments for other nodes in the codebase (you can grep “previousData”).

@gaearon gaearon added the bug label Aug 23, 2015
josebalius added a commit to josebalius/redux-devtools that referenced this issue Aug 23, 2015
@josebalius
Fix for issue reduxjs#83 - JSONObjectNode#getChildNodes: Cannot read …
b5a878d 
…property '...' of null (previousData)
@josebalius
Copy link
Contributor

@gaearon I submitted #84 to fix this. I added a null check everywhere previousData was checking for undefined.

gaearon added a commit that referenced this issue Aug 23, 2015
@gaearon
Merge pull request #84 from josebalius/master
92aaa5a 
Fix for issue #83 - JSONObjectNode#getChildNodes: Cannot read propert…
@gaearon
Copy link
Contributor

gaearon commented Aug 23, 2015

Should be fixed in 1.1.1.

@gaearon gaearon closed this as completed Aug 23, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josebalius @sompylasar @gaearon