Use 'system' format option for ES browser builds #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msutkowski
changed the title
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 47d2a7a https://deploy-preview-658--redux-starter-kit-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47d2a7a:
|
|
Just gave it a test, seems to be working well. Dependencies also seem to be bundled correctly, at least Some HTML to test locally, for the lazy ^^ <html>
<head>
<script type="module">
import {configureStore, createReducer } from './redux-toolkit.esm.development.mjs';
const reducer = createReducer([], {
test1(state, action) {
state.push(1)
},
test2(state, action) {
state.push(2)
}
},
[],
(state, action) => (console.log(action), state))
const store = configureStore({
reducer
})
const s1 = store.getState()
store.dispatch({type: "test1"})
const s2 = store.getState()
store.dispatch({type: "test2"})
const s3 = store.getState()
console.log({s1,s2,s3})
</script>
</head>
<body>
</body>
</html> |
phryneas
approved these changes
Jul 24, 2020
|
If it's approved all around, I'll drop a quick reference to this build by the UMD docs |
6 tasks
|
Do we want to get this out with 1.5? |
|
Probably a good idea :) |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #652.
This is 'hacky', but is the only way I can figure out how to get this to work with the current
tsdxlimitations.Uses the unused
systembuild format and just overrides the output for ES modules in the browserwith the same config Redux uses. Confirmed that the build does work by converting the Redux UMD example to useconfigureStore/createSlice.Update: I spent some more time reviewing the
tsdxsource, and the default configuration for any build is basically identical to the config Redux used, so I just simplified things. A working repo of the build from this last commit can be seen here: https://codesandbox.io/s/rtk-as-esm-browser-module-1lvrs?file=/index.html