-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[React Native] Upgrading to Babel 6 and/or adding .babelrc to .npmignore #1033
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Happy to accept a PR excluding it! (And maybe other useless files for good measure—except |
Also, hey, thanks for the heads up. |
OK - I wanted to make sure that excluding .babelrc was OK and you weren't shipping it next to src for some reason. |
Wondering how/whether this affects JSPM. |
I think you could make the argument that Babel shouldn't be processing .babelrc files under node_modules... imagine |
Usually people turn that off with Webpack/Browserify, but React Native Packager doesn't seem to offer/favor ignoring third-party modules? |
RN is in a unique situation where the JS files under node_modules are ES7, so we want Babel to transform them. But we want Babel to use only the config options that are specified when calling |
AFAIK JSPM doesn't care about |
Should be fixed in 3.0.5. |
Also add .babelrc to .npmignore so we don't have problems with React-Native's packager. Reference: reduxjs/redux#1033
Also add .babelrc to .npmignore so we don't have problems with React-Native's packager. Reference: reduxjs/redux#1033
Also add .babelrc to .npmignore so we don't have problems with React-Native's packager. Reference: reduxjs/redux#1033
It's not needed anyway. It's also causing issues when used with React-Native packager, which processes node_modules with Babel (reduxjs/redux#1033 (comment))
It's not needed anyway. It's also causing issues when used with React-Native packager, which processes node_modules with Babel (reduxjs/redux#1033 (comment))
It's not needed anyway. It's also causing issues when used with React-Native packager, which processes node_modules with Babel (reduxjs/redux#1033 (comment))
It's not needed anyway. It's also causing issues when used with React-Native packager, which processes node_modules with Babel (reduxjs/redux#1033 (comment))
It's not needed anyway. It's also causing issues when used with React-Native packager, which processes node_modules with Babel (reduxjs/redux#1033 (comment))
An alternative solution to bvaughn#19. I'm guessing @untone is dealing with the same problem that I am - an inability to use react-highlight-words since it's .babelrc is for Babel 5 and we're using Babel 6. See reduxjs/redux#1033 and reduxjs/redux-thunk#44 if more justification is required.
React Native will be shipping with Babel 6 in about three weeks. One consequence of this is that Babel finds .babelrc in
node_modules/redux
and tries to consume it -- since Redux is using Babel 5's configuration, this causes Babel 6 to crash. The current verdict is that packages will have to exclude .babelrc when distributed through npm: facebook/react-native#4062.The text was updated successfully, but these errors were encountered: