Updates to build for babel-preset-env #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found some improvements in bundle sizes in rollup/rollup-plugin-babel#100. While we have to wait for an upstream fix, it's at least got a workaround for now. The build failure appears to be something else going on (not 100% sure of the cause, but it finally reproduced itself locally, so I can fix it). That's not your fault, so this looks good to go. Thanks for the help! |
timdorr
pushed a commit
that referenced
this pull request
Nov 16, 2017
* Updates to build for babel-preset-env * Fixes for regenerator stuff in the output. Waiting on rollup/rollup-plugin-babel#100 and rollup/rollup#1595
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* Updates to build for babel-preset-env * Fixes for regenerator stuff in the output. Waiting on rollup/rollup-plugin-babel#100 and rollup/rollup#1595
tomipaul
pushed a commit
to tomipaul/redux
that referenced
this pull request
Apr 8, 2018
* Updates to build for babel-preset-env * Fixes for regenerator stuff in the output. Waiting on rollup/rollup-plugin-babel#100 and rollup/rollup#1595
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1342, this updates the redux build to use babel-preset-env to simplify things.
Updated the rollup config to use babel's
external-helpersplugin per the projects recommendation for babel configuration (https://github.com/rollup/rollup-plugin-babel#configuring-babel)I did a quick test in IE11 with a trivial create-react-app npm linked with this branch of redux and did not see anything issues 💯