Skip to content

extract store types from index.d.ts #3540

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2019
Merged

extract store types from index.d.ts #3540

merged 3 commits into from
Aug 30, 2019

Conversation

cellog
Copy link
Contributor

@cellog cellog commented Aug 30, 2019

This extracts the common types that will be shared between createStore and applyMiddleware into a separate file

@timdorr
Copy link
Member

timdorr commented Aug 30, 2019

Can we create a src/types path and put it in there?

@cellog
Copy link
Contributor Author

cellog commented Aug 30, 2019

done

@timdorr
Copy link
Member

timdorr commented Aug 30, 2019

OK, just renamed it to be a bit less redundant :)

@timdorr timdorr merged commit 146791c into reduxjs:ts-conversion Aug 30, 2019
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
@cellog @timdorr
extract store types from index.d.ts (reduxjs#3540)
a7b5e3e 
* extract store types from index.d.ts

* move storeTypes.ts into types/

* Rename storeTypes.ts to store.ts


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
Former-commit-id: 577abcb
Former-commit-id: 301ba7b
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
@cellog @timdorr
extract store types from index.d.ts (reduxjs#3540)
02ab29c 
* extract store types from index.d.ts

* move storeTypes.ts into types/

* Rename storeTypes.ts to store.ts


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
Former-commit-id: 577abcb
Former-commit-id: 301ba7b
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cellog @timdorr