Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update UsageWithTypescript.md #4642

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

factiondavid
Copy link
Contributor

Include id type for Book entity


name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page

Checklist

  • Is there an existing issue for this PR?
    - link issue here
  • [x ] Have the files been linted and formatted?

What docs page needs to be fixed?

  • Section:
  • Page:

What is the problem?

selectId does not set the custom id for the createEntityAdapter as it needs the custom id tpe.

What changes does this PR make to fix the problem?

Elimates the TS error

Include id type for Book entity
Copy link

codesandbox-ci bot commented Dec 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 30b6668:

Sandbox Source
Vanilla Typescript Configuration

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for redux-docs ready!

Name Link
🔨 Latest commit 30b6668
🔍 Latest deploy log https://app.netlify.com/sites/redux-docs/deploys/65833635a3f30300084b14af
😎 Deploy Preview https://deploy-preview-4642--redux-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Ben Durrant <ben.j.durrant@gmail.com>
@EskiMojo14 EskiMojo14 merged commit 3cd25e1 into reduxjs:master Dec 20, 2023
5 checks passed
@EskiMojo14
Copy link
Contributor

thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants