Remove getReducer() from Store API #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
added a commit
that referenced
this pull request
Aug 31, 2015
Remove getReducer() from Store API
This was referenced Aug 31, 2015
|
Can we issue a deprecation warning in development builds for |
|
(In the 1.0 branch that is) |
|
We can, although I expect it to be called by React Redux in 99% cases. I don't think anybody else used it.. We need to release React Redux 2.0 that wouldn't use it. |
|
Given Redux's small API surface, it's probably overkill if there's no affordance for it already. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only needed because React Redux used it to magically allow reducer hot reloading.
This magic used to cause problems (#301, #340), so we made the usage of
replaceReducer()for hot reloading explicit (#667). Now that it is explicit, there is no need forgetReducer()so it can safely be removed from the public API.This is a breaking change, so it goes into
wip-2.0branch.