Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Clerk to use Clerk Core 2 #11700

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

justinadkins
Copy link

This PR updates redwood's usage of Clerk authentication to Clerk Core 2 which was introduced back in April 2024 as the new major version for Clerk.

Core 1 which is currently being used by Redwood will lose long term support in Q1 2025.

Core 2 also brings with it a lot of nice UI updates with @clerk/clerk-react@5.x seeing considerable improvements.

@justinadkins
Copy link
Author

justinadkins commented Oct 17, 2024

This is nearly ready to go, I'm running into a TS build error due to this that I could use assistance on.

Screenshot 2024-10-17 at 3 25 55 PM

@Tobbe
Copy link
Member

Tobbe commented Oct 20, 2024

Thanks for getting started on this. The types for our auth setup are pretty complicated 😰 I wrote all of that, so I'm probably bet suited to jump in to help here, but unfortunately I'm super busy with upcoming conference talks and our RSC implementation. We have a team meeting on Tuesday. I'll see if I can ask someone else to take a look!

@Tobbe Tobbe self-assigned this Oct 20, 2024
@Tobbe
Copy link
Member

Tobbe commented Oct 24, 2024

Unfortunately no one was available to help. I'll see if I can carve out some time next week. I'm out traveling until Sunday.

@Tobbe
Copy link
Member

Tobbe commented Nov 20, 2024

@justinadkins Just wanted to let you know I/we haven't forgotten about this PR. I'll personally make sure this gets merged. But it'll be some time still before I can spend time on it. I'm doing my last talk of the year next week. So the week after that I will have time for this

(We've decided to do an overhaul of all of our auth providers, so this fits perfectly with that initiative!)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants