Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(telemetry): Redact additional information #8232

Merged
merged 2 commits into from
May 5, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Problem
Some information was being picked up by lint and exec which we do not want to hold.

Changes

  1. Adds an allowOnly to redact commands which take arb. length inputs like lint
  2. Adds this option to lint and exec to perform these additional redactions.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label May 5, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally

@jtoar jtoar merged commit 02b34a4 into main May 5, 2023
@jtoar jtoar deleted the jgmw-telemetry/fix-redact-lint-and-exec branch May 5, 2023 21:12
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 5, 2023
@jtoar jtoar modified the milestones: next-release, next-release-patch May 5, 2023
@jtoar jtoar modified the milestones: next-release-patch, v5.0.6 May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants