Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add metainfo to keyevent #4287

Merged
merged 13 commits into from
Nov 6, 2024
Merged

add metainfo to keyevent #4287

merged 13 commits into from
Nov 6, 2024

Conversation

adhami3310
Copy link
Member

No description provided.

@adhami3310 adhami3310 changed the base branch from allow-for-event-handlers-to-ignore-args to main November 6, 2024 17:22
@adhami3310 adhami3310 marked this pull request as ready for review November 6, 2024 17:26
masenf
masenf approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the isort formatting change probably should have come in a separate PR to make this easier to review the actual change, but looks good.

@adhami3310 adhami3310 merged commit b9d73ed into main Nov 6, 2024
34 checks passed
@adhami3310 adhami3310 deleted the add-metainfo-to-keyevent branch November 6, 2024 23:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf