Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow disabling auto-setters via state_auto_setters config #4480

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

benedikt-bartscher
Copy link
Contributor

Closes #4477

@benedikt-bartscher
Copy link
Contributor Author

might be better to put this in rx.Config

@benedikt-bartscher benedikt-bartscher changed the title feat: allow disabling auto-setters via REFLEX_AUTO_CREATE_SETTERS feat: allow disabling auto-setters via state_auto_setters config Dec 4, 2024
@benedikt-bartscher
Copy link
Contributor Author

might be better to put this in rx.Config

I refactored it to rx.Config, but it seems like this causes a circular import for reflex-web :/

@benedikt-bartscher benedikt-bartscher marked this pull request as ready for review December 4, 2024 23:36
@benedikt-bartscher benedikt-bartscher marked this pull request as draft December 4, 2024 23:44
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #4480 will not alter performance

Comparing benedikt-bartscher:disable-auto-setters (ab3af5c) with main (85f07fc)

Summary

✅ 8 untouched benchmarks

@adhami3310
Copy link
Member

adhami3310 commented Feb 3, 2025

blocked on reflex-dev/reflex-web#1205

@benedikt-bartscher
Copy link
Contributor Author

blocked on #1205

Wrong number? Does not seem related.

Thanks for rebasing!

@adhami3310
Copy link
Member

Wrong number? Does not seem related.

yea it was from reflex-web

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config option to disable reflex auto-generated setters (set_varname)
2 participants