Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix duplicate tab issue #4607

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix duplicate tab issue #4607

wants to merge 5 commits into from
+42 −21

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Jan 8, 2025

fix #4605

masenf
masenf reviewed Jan 9, 2025
View reviewed changes
@masenf
Copy link
Collaborator

masenf commented Jan 21, 2025

Revisiting this PR, is there ever a case where we wouldn't get on_disconnect to unlink the sid/token, resulting in a refresh/reconnect leading to loss of token and state for a client?

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #4607 will not alter performance

Comparing lendemor/fix_duplicate_tab_issue (d2b183e) with main (c2917d4)

Summary

✅ 12 untouched benchmarks

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@masenf masenf masenf left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated tabs interfere with each other during background events
2 participants
@Lendemor @masenf