Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

auto hide badge for pro+ users for cloud deployments #4819

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

Lendemor
Copy link
Collaborator

If show_built_with_reflex is not specified, it will default to False for pro+ users.
Using that config knob is still reserved for pro+ users, and value will be set to True for free users.

Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #4819 will not alter performance

Comparing lendemor/default_badge_off (a5b8043) with main (10bae95)

Summary

✅ 12 untouched benchmarks

masenf
masenf previously approved these changes Feb 13, 2025
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, test needs to be adjusted to set the env var instead of the config knob when simulating a deploy

@Lendemor Lendemor requested a review from masenf February 15, 2025 00:17
@Lendemor Lendemor merged commit 0a33cc3 into main Feb 19, 2025
43 checks passed
@Lendemor Lendemor deleted the lendemor/default_badge_off branch February 19, 2025 17:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants