Fix Reflex.Profiled infinite recursion for merge incremental #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Reflex Profiled transformer had an incorrect definition for Reflex.Class.mergeIncrementalG and Reflex.Class.mergeIncrementalWithMoveG. Instead of calling the transformed inner Reflex timeline, it called itself, leading to an infinite recursion. This is fixed by coercing the type before running mergeIncremental*. This was introduced in 8d8ceec, and effects Reflex v0.6.2.1, v0.6.2.2, v0.6.2.3, v0.6.2.4, v0.6.3, and v0.6.4.
ali-abrar
approved these changes
Feb 4, 2020
|
The Travis failure is spurious, yet again. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reflex Profiled transformer had an incorrect definition for
Reflex.Class.mergeIncrementalG and
Reflex.Class.mergeIncrementalWithMoveG. Instead of calling the
transformed inner Reflex timeline, it called itself, leading to an
infinite recursion. This is fixed by coercing the type before running
mergeIncremental*.
This was introduced in 8d8ceec, and
effects Reflex v0.6.2.1, v0.6.2.2, v0.6.2.3, v0.6.2.4, v0.6.3, and
v0.6.4.