Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Nits #399

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Nits #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dd10b8
Fix hack-on instructions
endgame Mar 5, 2020
244eba8
Query: fix haddock
endgame Mar 5, 2020
c373c46
Merge branch 'develop' into nits
3noch Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,11 @@ A summary of Reflex functions is available in the [quick reference](Quickref.md)

### Hacking

Use the `./scripts/hack-on reflex` script in [Reflex Platform](https://github.com/reflex-frp/reflex-platform) to checkout the source code of `reflex` locally in `reflex-platform/reflex` directory.
Then do modifications to the source in place, and use the `./try-reflex` or `./scripts/work-on` scripts to create the shell to test your changes.
From the root of a [Reflex
Platform](https://github.com/reflex-frp/reflex-platform) checkout, run
`./scripts/hack-on haskell-overlays/reflex-packages/dep/reflex`. This
will check out the reflex source code into the
`haskell-overlays/reflex-packages/dep/reflex` directory. You can then
point that checkout at your fork, make changes, etc. Use the
`./try-reflex` or `./scripts/work-on` scripts to start a shell in
which you can test your changes.
2 changes: 1 addition & 1 deletion src/Reflex/Query/Class.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ instance Group SelectedCount where

instance Additive SelectedCount

-- | The Semigroup/Monoid/Group instances for a Query containing 'SelectedCount's should use
-- | The Semigroup\/Monoid\/Group instances for a Query containing 'SelectedCount's should use
-- this function which returns Nothing if the result is 0. This allows the pruning of leaves
-- of the 'Query' that are no longer wanted.
combineSelectedCounts :: SelectedCount -> SelectedCount -> Maybe SelectedCount
Expand Down