Update tsconfig.json to use use node16 module resolution

[ChristianMurphy]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Additionally scopes JSON module to the one (CJS) location where it is used.

[wooorm]

Where is JSON still required? 🤔

[codecov-commenter]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c898b77) compared to base (b9e9b99).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          460       460           
=========================================
  Hits           460       460           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ChristianMurphy]

Where is JSON still required? 🤔

rehype/packages/rehype-cli/cli.js

Lines 8 to 9 in b9e9b99

	const proc = require('rehype/package.json')
	const cli = require('./package.json')

[wooorm]

Ohh yeah... That's been a while. I'll probably hardcode it soon. Weird that ts doesn't understand you can do that with cjs

[ChristianMurphy]

Weird that ts doesn't understand you can do that with cjs

Well this file technically isn't CJS, it's ESM, with a custom CJS resolve defined inside it 😅

rehype/packages/rehype-cli/cli.js

Line 6 in c898b77

const require = createRequire(import.meta.url)

[remcohaszing]

It kind of understands. With "module": "node16", the following TypeScript:

import foo = require('bar')

gets compiled to:

import { createModule } from 'node:module'

const require = createModule(import.meta.url)

const foo = require('bar')

But indeed, it doesn’t understand if this is written manually, whether in JS or TS..

[remcohaszing]

Still, I think resolveJsonModule isn’t needed to be able to require JSON files like that?

[ChristianMurphy]

Still, I think resolveJsonModule isn’t needed to be able to require JSON files like that?

I agree it likely shouldn't be required.
But it currently is.
Removing the option results in:

cli.js:8:22 - error TS2732: Cannot find module 'rehype/package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension.

8 const proc = require('rehype/package.json')
                       ~~~~~~~~~~~~~~~~~~~~~

cli.js:9:21 - error TS2732: Cannot find module './package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension.

9 const cli = require('./package.json')
                      ~~~~~~~~~~~~~~~~

[wooorm]

Well this file technically isn't CJS, it's ESM, with a custom CJS resolve defined inside it 😅

It knows that it is a require call right, as it resolves things from it. Presumably it can differentiate between imports and requires. So I don’t understand why it treats it as if it would use “ESM”/import semantics instead of “CJS”/require ones

[wooorm]

Thanks!

[remcohaszing]

I agree it likely shouldn't be required.
But it currently is.

I really thought it was required, but shouldn’t be! Anyway, I have no further comments if it is.