Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

modal-patch-mobile #199

Merged
merged 4 commits into from
Jan 17, 2025
Merged

modal-patch-mobile #199

merged 4 commits into from
Jan 17, 2025

Conversation

sikhote
Copy link
Contributor

@sikhote sikhote commented Jan 15, 2025

Description

The modal positioning was broken on some older versions of Chrome, due to adding the following to body via the cdr-reset file:

  container-name: cdr-body;
  container-type: inline-size;

This changed was implemented to make it easier for container queries to "just work". However, having a container CSS property applied to the body means that any inner content with a position fixed can be affected in some older browsers—the content would not longer be sticky...it would just stick to the top of "body". For this reason, I have removed it from our reset file. In the future, we may want to add a similar set of styles to CdrContainer. The change for CdrContainer is not added here for the following reasons:

  • this is meant as more of a quick fix
  • the styles for CdrContainer come from cdr-tokens
  • because of the position fixed issue, it may not be best to release the container change within a major version change
  • it's not crucial

@sikhote sikhote self-assigned this Jan 15, 2025
@sikhote sikhote merged commit e1b2fe8 into main Jan 17, 2025
3 checks passed
@sikhote sikhote deleted the pr/modal-patch-mobile branch January 17, 2025 17:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants