Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modal positioning was broken on some older versions of Chrome, due to adding the following to body via the cdr-reset file:
This changed was implemented to make it easier for container queries to "just work". However, having a container CSS property applied to the body means that any inner content with a position fixed can be affected in some older browsers—the content would not longer be sticky...it would just stick to the top of "body". For this reason, I have removed it from our reset file. In the future, we may want to add a similar set of styles to CdrContainer. The change for CdrContainer is not added here for the following reasons: