Ensure filtered params aren't revealed in sql #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyevil
force-pushed
the
filter-bind-values
branch
from
6631b88 to
aa1e03b
Compare
4 tasks
|
@reidmorrison Do you have time to review this? |
|
@reidmorrison any chance this could be merged? 🙏 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #187
Sensitive information may accidentally be sent to third party applications via the bind values of the SQL statements logged using semantic logger
Description of changes
If a bind key is included in the
filter_parametersinRails.configurationvalue is set as"[FILTERED]"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.