dead code 17

rekalogika · Jul 18, 2024 · 7e79452 · 7e79452
1 parent cff10d2
commit 7e79452
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 6 deletions.
diff --git a/packages/collections-contracts/src/ReadableRecollection.php b/packages/collections-contracts/src/ReadableRecollection.php
@@ -29,10 +29,8 @@ interface ReadableRecollection extends PageableInterface, ReadableCollection
     // Overridden methods, to widen keys in parameters to accommodate Uuid key
     // types
     //
-
     /**
      * @param mixed $key
-     * @return bool
      */
     #[\Override]
     public function containsKey(mixed $key): bool;

diff --git a/packages/collections-domain/src/CriteriaPageable.php b/packages/collections-domain/src/CriteriaPageable.php
@@ -96,7 +96,6 @@ final private function __construct(
      * @template ST
      * @param ReadableCollection<STKey,ST>|Selectable<STKey,ST> $collection
      * @param int<1,max> $itemsPerPage
-     * @return static
      */
     final public static function create(
         ReadableCollection|Selectable $collection,

diff --git a/packages/collections-orm/src/QueryPageable.php b/packages/collections-orm/src/QueryPageable.php
@@ -81,7 +81,6 @@ final public function getQueryBuilder(): QueryBuilder
 
     /**
      * @param \Closure(QueryBuilder):void $function
-     * @return static
      */
     final public function updateQueryBuilder(\Closure $function): static
     {

diff --git a/packages/collections-orm/src/QueryRecollection.php b/packages/collections-orm/src/QueryRecollection.php
@@ -114,7 +114,6 @@ final public function getQueryBuilder(): QueryBuilder
 
     /**
      * @param \Closure(QueryBuilder):void $function
-     * @return static
      */
     final public function updateQueryBuilder(\Closure $function): static
     {

diff --git a/rector.php b/rector.php
@@ -35,7 +35,7 @@
         // symfonyCodeQuality: true,
         // doctrineCodeQuality: true,
     )
-    ->withDeadCodeLevel(16)
+    ->withDeadCodeLevel(17)
     ->withPhpSets(php82: true)
     ->withRules([
         // AddOverrideAttributeToOverriddenMethodsRector::class,
@@ -48,6 +48,7 @@
         ],
         RemoveUselessReturnTagRector::class => [
             // static analysis tools don't like this
+            __DIR__ . '/packages/collections-common/src/Trait/ReadableCollectionTrait.php',
             __DIR__ . '/packages/collections-common/src/Trait/MinimalReadableRecollectionTrait.php',
             __DIR__ . '/packages/collections-common/src/Trait/ReadableRecollectionTrait.php',
             __DIR__ . '/packages/collections-contracts/src/MinimalReadableRecollection.php',
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,7 +81,6 @@ final public function getQueryBuilder(): QueryBuilder @@
         /**
          * @param \Closure(QueryBuilder):void $function
-         * @return static
          */
         final public function updateQueryBuilder(\Closure $function): static
         {
@@ Expand Down @@