fix order of changing state #108
Merged
+36
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 83.73% 83.73%
=======================================
Files 43 43
Lines 2281 2281
=======================================
Hits 1910 1910
Misses 371 371Continue to review full report at Codecov.
|
keigohtr
reviewed
Jun 15, 2019
| @@ -88,7 +88,7 @@ class AddModelFileFormImpl extends React.Component<AddModelFileFormProps, AddMod | |||
| validationSchema={AddModelFileSchema} | |||
| onSubmit={this.onSubmit} | |||
| onReset={this.onCancel}> | |||
| {({ errors, touched, setFieldValue, isSubmitting }) => ( | |||
| {({ errors, touched, setFieldValue }) => ( | |||
There was a problem hiding this comment.
You don't need to rewrite here. You can write this like this way.
keigohtr
approved these changes
Jun 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
fix error caused by second requests of API,
Currently display the previous result as notification because
prevStateof getDerivedStateFromProps is actually not previous state, so followings happen.(e.g. upload model)
setState({submitting: true})in onSubmit, getDerivedStateFromProps is calleduploadModelStatusis already success or fail, depending on the previous resultnextState.submittingis true, so display the previous result as notfiication, not waiting for the current API request to return responseThis PR includes
state.formbecause it is not used ( ca718a2 )prevStateto nextState` in getDerivedStateFromProps ( e0e1f75 )isSubmittingbecause it does not change when API request failed ( 89e3ddc )What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?
write a method and a sample of command