Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] Allow /api/settings in auth module #26

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Conversation

sugyan
Copy link
Member

@sugyan sugyan commented Aug 27, 2018

What is this PR for?

Due to the change in #17, all API requests become error when authentication is enabled.
This is a hotfix for it.

This PR includes

  • Fix the path what @auth_required decorator ignores authentication processing

What type of PR is it?

Bugfix

What is the issue?

N/A

How should this be tested?

Activated the auth part of settings.yml

Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
How do you think @yustoris ?

@keigohtr keigohtr changed the title Allow /api/settings in auth module [Hotfix] Allow /api/settings in auth module Aug 27, 2018
@keigohtr keigohtr merged commit 94d1a6b into master Aug 27, 2018
@keigohtr keigohtr deleted the hotfix/auth-settings branch August 27, 2018 07:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants