Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] Add encode info #34

Merged
merged 1 commit into from
Oct 1, 2018
Merged

[Hotfix] Add encode info #34

merged 1 commit into from
Oct 1, 2018

Conversation

keigohtr
Copy link
Member

What is this PR for?

To dump a Kubernetes service configuration file, we have to specify an encoding info for Japanese characters.

This PR includes

  • Add encoding info when write file.

What type of PR is it?

Bugfix

What is the issue?

N/A

How should this be tested?

Save Japanese character in memo

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sugyan sugyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@keigohtr
Copy link
Member Author

keigohtr commented Oct 1, 2018

Thank you :)

@keigohtr keigohtr merged commit cf804f9 into master Oct 1, 2018
@keigohtr keigohtr deleted the hotfix/add-encode-info branch October 1, 2018 00:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants