[Hotfix] Fix file upload limit for gRPC and flask #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keigohtr
requested review from
sugyan,
yoquankara,
yustoris,
jkw552403,
yuki-mt and
shimpei-yotsukura
|
|
yoquankara
reviewed
Sep 28, 2018
| @@ -19,6 +19,6 @@ def serialize_to_object(proto, descriptor = None): | |||
| return result | |||
|
|
|||
| @staticmethod | |||
| def stream_file(f:FileStorage, size:int=100*1024*1024) -> bytes: | |||
| def stream_file(f:FileStorage, size:int=4190000) -> bytes: | |||
There was a problem hiding this comment.
nit: this value looks arbitrary...
There was a problem hiding this comment.
Upper transference limit is 4MB, so we cannot occupy 4MB for file transference. The rest band is for head info and so on.
There was a problem hiding this comment.
Ok, so we have 4304 bytes left for header info which seems enough.
There was a problem hiding this comment.
Yes.
I didn't calculate an edge case. I believe that about 4KB is enough for the other info.
yoquankara
approved these changes
Oct 1, 2018
| @@ -19,6 +19,6 @@ def serialize_to_object(proto, descriptor = None): | |||
| return result | |||
|
|
|||
| @staticmethod | |||
| def stream_file(f:FileStorage, size:int=100*1024*1024) -> bytes: | |||
| def stream_file(f:FileStorage, size:int=4190000) -> bytes: | |||
There was a problem hiding this comment.
Ok, so we have 4304 bytes left for header info which seems enough.
|
Thank you! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Modify the file upload limit for gRPC and flask.
Since default gRPC settings limits 4MB data for transference in an one connection, we need to fix our file transference setting.
This PR includes
What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?
Upload ML model more than 4MB.