[Hotfix] Fix switchModel API response handler
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keigohtr
requested review from
sugyan,
yoquankara,
yustoris,
jkw552403,
yuki-mt and
shimpei-yotsukura
yoquankara
reviewed
Nov 1, 2018
| @@ -814,6 +814,7 @@ def switch_drucker_service_model_assignment( | |||
| name="{0}-deployment".format(sobj.service_name), | |||
| namespace=sobj.service_level | |||
| ) | |||
| response_body["status"] = True | |||
There was a problem hiding this comment.
It might fix the problem, but meaning of status as True seems confusing.
status is often like OK, NG etc.
Did response_body["success"] = True not work?
There was a problem hiding this comment.
All backend responses return response_body["status"] = True now. If we change it to response_body["success"] = True, we need to replace all fields in backend and frontend.
We may use status as integer, but may change in the next PR.
There was a problem hiding this comment.
Yes, a separate PR is better.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Switching model is always shown as failure on WebUI but actually success.
This is because our API response handler didn't catch the status correctly.
This PR includes
What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?
Switch model on WebUI.