-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add cascade deletion for application_user_roles #56
Add cascade deletion for application_user_roles #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 79.12% 79.26% +0.13%
==========================================
Files 36 36
Lines 1586 1596 +10
==========================================
+ Hits 1255 1265 +10
Misses 331 331
Continue to review full report at Codecov.
|
12c4afd
to
d84bea3
Compare
If you are using Ref: https://docs.sqlalchemy.org/en/latest/orm/collections.html#using-passive-deletes |
@yoquankara Thank you for reviewing this! |
5b4950b
to
e57a8f2
Compare
@keigohtr Looks good! Could you also delete the line https://github.com/rekcurd/drucker-dashboard/blob/master/drucker_dashboard/apis/api_evaluation.py#L87-L88 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is this PR for?
Because of the
ForeignKey
, we cannot deleteApplication
model when we use an authentication.This PR includes
backref
to delete orphanquery().delete()
doesn't support cascade deletion (See link)What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?