[Bugfix]add logger option to db handler for KeyError #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-mt
changed the title
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 42 42
Lines 2080 2080
=======================================
Hits 1763 1763
Misses 317 317Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If db_handler does not have
loggeroption,args["logger"] here causes
KeyError: 'logger', so I added it.This PR includes
What type of PR is it?
Bugfix
What is the issue?
N/A
How should this be tested?
rekcurd_dashboard db init --settings rekcurd_dashboard/template/settings.yml-tpl