Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add settings.yml template generation script #93

Merged
merged 2 commits into from
May 16, 2019

Conversation

keigohtr
Copy link
Member

What is this PR for?

Add settings.yml template generation script

This PR includes

  • Add CLI option to generate settings.yml

What type of PR is it?

Feature

What is the issue?

N/A

How should this be tested?

N/A

@keigohtr keigohtr self-assigned this Apr 26, 2019
@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files          42       42           
  Lines        2098     2098           
=======================================
  Hits         1756     1756           
  Misses        342      342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4f7e5...180ab97. Read the comment docs.

@yuki-mt
Copy link
Member

yuki-mt commented May 9, 2019

@keigohtr
It seems better to describe rekcurd_dashboard template command in README.md and/or rekcurd_dashboard/README.md

@keigohtr
Copy link
Member Author

keigohtr commented May 9, 2019

@yuki-mt Thank you for your review.
I have updated README.md !

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit 4be3d75 into master May 16, 2019
@keigohtr keigohtr deleted the feature/generate-template branch May 16, 2019 23:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants