Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add GCS support #95

Merged
merged 1 commit into from
May 16, 2019
Merged

Add GCS support #95

merged 1 commit into from
May 16, 2019

Conversation

keigohtr
Copy link
Member

@keigohtr keigohtr commented May 8, 2019

What is this PR for?

Add GCS support

This PR includes

  • Add GcsHandler
  • Add UI for gcs mode
  • Add test

What type of PR is it?

Feature

What is the issue?

#69

How should this be tested?

Run unittest

@keigohtr keigohtr self-assigned this May 8, 2019
@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #95 into master will increase coverage by 0.08%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   83.69%   83.77%   +0.08%     
==========================================
  Files          42       42              
  Lines        2098     2127      +29     
==========================================
+ Hits         1756     1782      +26     
- Misses        342      345       +3
Impacted Files Coverage Δ
rekcurd_dashboard/apis/kubernetes_handler.py 82.95% <ø> (ø) ⬆️
rekcurd_dashboard/models/data_server.py 93.18% <100%> (+5.37%) ⬆️
rekcurd_dashboard/apis/api_data_server.py 95.39% <80.76%> (-3.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4f7e5...95c1355. Read the comment docs.

Copy link
Member

@yuki-mt yuki-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keigohtr keigohtr merged commit dcc1a0b into master May 16, 2019
@keigohtr keigohtr deleted the feature/gcs-support branch May 16, 2019 23:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants