Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Hotfix] Change code generator #3

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Conversation

keigohtr
Copy link
Member

@keigohtr keigohtr commented Aug 8, 2018

Since #1 extend the existing function, we need to change code-generator.
I will close #2 PR because it requires an additional file.

@jkw552403
Copy link

This script worked well on my desktop and I have a question about do we still the -I/usr/local/include option?

It seems that the Python command still works without that option on my desktop.

@keigohtr
Copy link
Member Author

keigohtr commented Aug 8, 2018

@jkw552403
Yes, we don't need it.
I will remove it. Thanks.

Copy link
Member

@yoquankara yoquankara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit d5092a1 into master Aug 9, 2018
@keigohtr keigohtr deleted the hotfix/change-code-generator branch August 9, 2018 00:15
keigohtr added a commit that referenced this pull request Oct 16, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants