Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

save and load evaluation result gragually #16

Merged
merged 1 commit into from
Apr 18, 2019
Merged

save and load evaluation result gragually #16

merged 1 commit into from
Apr 18, 2019

Conversation

yuki-mt
Copy link
Member

@yuki-mt yuki-mt commented Mar 27, 2019

What is this PR for?

prevent OOM with large List[EvaluateResultDetail] data

This PR includes

What type of PR is it?

Feature/Bugfix/....

What is the issue?

N/A

How should this be tested?

write a method and a sample of command

@yuki-mt yuki-mt self-assigned this Mar 27, 2019
@yuki-mt yuki-mt requested a review from keigohtr March 27, 2019 12:39
@yuki-mt
Copy link
Member Author

yuki-mt commented Mar 27, 2019 •
edited
Loading

I will merge this PR after rekcurd/rekcurd-python#44 is released

keigohtr
keigohtr approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@keigohtr keigohtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keigohtr keigohtr merged commit b3ab9df into master Apr 18, 2019
@keigohtr keigohtr deleted the feature/prevent_OOM_due_to_evaluation_data branch April 18, 2019 08:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@keigohtr keigohtr keigohtr approved these changes

Assignees

@yuki-mt yuki-mt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-mt @keigohtr