feat: export domhandler's Element to support instanceof checks #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarkablemark
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Thanks for opening this PR @natterstefan, I left some comments but otherwise it looks good!
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 8 +1
Lines 135 153 +18
Branches 49 53 +4
=========================================
+ Hits 135 153 +18
Continue to review full report at Codecov.
|
index.js → dist/html-react-parser.min.js...
created dist/html-react-parser.min.js in 975ms
/usr/local/bin/npx size-limit --json
[
{
"name": "dist/html-react-parser.min.js",
"passed": true,
"size": 9226,
"running": 0.07007999999999999,
"loading": 0.1801953125
}
] |
|
Release 1.4.0 |
This was referenced Oct 1, 2021
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
It's a feature that resolves what we have discussed here (and suggested by others as well).
What is the current behavior?
Currently, one has to import
Elementby fromdomhandlermanually, after adding it to the project, while it is already adependencyof this package.What is the new behavior?
html-react-parserexports theElementtype ofdomhandleralready, but not the runtime version of it. This PR fixes it.Checklist:
I also added another CRA example for TypeScript and linked it in the
README.mdfile.Related Issues
resolves #252
resolves #221 (most likely too)
resolves #199