Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sort Apollo.rip results by number of seeders #3124

Merged
merged 1 commit into from
Aug 14, 2018
Merged

sort Apollo.rip results by number of seeders #3124

merged 1 commit into from
Aug 14, 2018

Conversation

nopoz
Copy link
Contributor

@nopoz nopoz commented Jul 3, 2018

Previous behavior was to arbitrarily pick torrent by size. This commit will instead pick the torrent with the highest amount of seeders. This filtering is preferred as the torrent with the highest amount of seeders is generally the best result - community consensus of which upload is best by popularity, provides the fastest download speed, and gives you the most upload potential.

Testing results:

id 1159880 = 194 seeders
id 1163752 = 9 seeders
id 1162109 = 6 seeders

03-Jul-2018 09:43:04 - INFO    :: CP Server Thread-6 : Marking album: a63e5fa6-d6ad-47bd-986d-4a27b0c9de70 as wanted...
03-Jul-2018 09:43:04 - INFO    :: CP Server Thread-6 : Searching for wanted albums
03-Jul-2018 09:43:04 - INFO    :: CP Server Thread-6 : Searching for "Nine Inch Nails - Bad Witch" since it was marked as wanted
03-Jul-2018 09:43:04 - DEBUG   :: CP Server Thread-6 : Using search term: Nine Inch Nails Bad Witch
03-Jul-2018 09:43:04 - INFO    :: CP Server Thread-6 : Attempting to log in to Apollo.rip...
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : Searching Apollo.rip...
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : Filtering torrents by format, maximum size, and minimum seeders...
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : Remaining torrents: Torrent: Bad Witch - V0 (VBR) - ID: 1163752, Torrent: Bad Witch - V0 (VBR) - ID: 1159880, Torrent: Bad Witch - V0 (VBR) - ID: 1162109
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : Found 3 matching releases from Apollo.rip for Nine Inch Nails - Bad Witch after filtering
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : Sorting torrents by number of seeders...
03-Jul-2018 09:43:06 - INFO    :: CP Server Thread-6 : New order: Torrent: Bad Witch - V0 (VBR) - ID: 1159880, Torrent: Bad Witch - V0 (VBR) - ID: 1163752, Torrent: Bad Witch - V0 (VBR) - ID: 1162109
03-Jul-2018 09:43:07 - INFO    :: CP Server Thread-6 : Removed 'Nine Inch Nails   2018   Bad Witch (44 1 16 Vinyl Rip) (V0)' from results because it contains ignored word: 'vinyl'
03-Jul-2018 09:43:07 - INFO    :: CP Server Thread-6 : Making sure we can download the best result
03-Jul-2018 09:43:07 - INFO    :: CP Server Thread-6 : Found best result from Apollo.rip: <a href="https://apollo.rip/torrents.php?action=download&id=1159880&authkey=XXX&torrent_pass=XXX">Nine Inch Nails - Bad Witch (2018) [V0 WEB]</a> - 60.0 MB
03-Jul-2018 09:43:07 - INFO    :: CP Server Thread-6 : Sending torrent to Transmission
03-Jul-2018 09:43:07 - DEBUG   :: CP Server Thread-6 : Requesting URL via GET method: http://localhost:9091/transmission/rpc
03-Jul-2018 09:43:07 - DEBUG   :: CP Server Thread-6 : Retrying Transmission request with new session id
03-Jul-2018 09:43:07 - DEBUG   :: CP Server Thread-6 : Requesting URL via POST method: http://localhost:9091/transmission/rpc

result is id 1159880 with the most seeders snatched

@nopoz
Copy link
Contributor Author

nopoz commented Jul 19, 2018

@AdeHub looks like you're doing most of the merging these days - can you review my pull requests?

@AdeHub AdeHub merged commit 22b1bf3 into rembo10:develop Aug 14, 2018
@AdeHub
Copy link
Collaborator

AdeHub commented Aug 14, 2018

👍

@nopoz nopoz deleted the develop branch November 8, 2018 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants