Skip to content

Fix actionResult type on shouldRevalidate args #10779

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

markdalgleish
Copy link
Member

Fixes remix-run/remix#5759.

This type issue was picked up if I added type annotations to the args objects in the test suite, so I've also added those as part of this fix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: 0d5dacf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the base branch from main to dev August 11, 2023 01:59
@markdalgleish markdalgleish force-pushed the markdalgleish/should-revalidate-action-result-type branch from 417b3f6 to e5dbd73 Compare August 11, 2023 02:08
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I moved the types in the docs into a collapsed details/summary section - we're inconsistent across the site so I've been aligning them as I come across them.

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.16.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

ShouldRevalidateFunction's actionResult type doesn't match its contents
2 participants