-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Fix actionResult type on shouldRevalidate args #10779
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix actionResult type on shouldRevalidate args #10779
Conversation
🦋 Changeset detectedLatest commit: 0d5dacf The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
417b3f6
to
e5dbd73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I moved the types in the docs into a collapsed details
/summary
section - we're inconsistent across the site so I've been aligning them as I come across them.
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes remix-run/remix#5759.
This type issue was picked up if I added type annotations to the args objects in the test suite, so I've also added those as part of this fix.