Properly handle empty body response codes in single fetch requests #12760
Conversation
🦋 Changeset detectedLatest commit: 754f590 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I left that out on purpose, but incorrectly it seems. I thought document requests would always need an HTML body - and in the 304 case it would use the cached body. I missed that the browser will behave the same on 204 responses and use the current document:
205 behaves the same - although interestingly enough it doesn't reset any form fields. I don't think 1xx makes sense for document requests? I'm going to leave those out and only apply them to data requests (even there I don't have a great use case for them...) |
brophdawg11
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
| // some status codes are not permitted to have bodies, so we want to just | ||
| // treat those as "no data" instead of throwing an exception. | ||
| // 304 is not included here because the browser should fill those responses | ||
| // with the cached body content. | ||
| const NO_BODY_STATUS_CODES = new Set([100, 101, 204, 205]); | ||
| if (NO_BODY_STATUS_CODES.has(res.status)) { | ||
| if (!init.method || init.method === "GET") { | ||
| // SingleFetchResults can just have no routeId keys which will result | ||
| // in no data for all routes | ||
| return { status: res.status, data: {} }; | ||
| } else { | ||
| // SingleFetchResult is for a singular route and can specify no data | ||
| return { status: res.status, data: { data: undefined } }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Edit: NVM, I misunderstood the spec. This is great.
Closes remix-run/remix#10328