Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix bug with search params removal #9969

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

brophdawg11
Copy link
Contributor

If a user provides an initial set of search params with useSearchParams({ key: 'initial' }) we only want to leverage that value initially, but not once they've applied new params via a setSearchParams call

Closes #9668

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023

🦋 Changeset detected

Latest commit: b8dea4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router-native Patch
react-router Patch
react-router-dom-v5-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit e29876c into dev Jan 24, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-search-params-removal branch January 24, 2023 21:19
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.7.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useSearchParams reverts to default value when removing the last value
3 participants