chore(docs,examples,templates): quote glob run params in build command
#2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref mysticatea/npm-run-all#200 Fix remix-run#2033 from: https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type from: https://www.conventionalcommits.org/en/v1.0.0/ from: https://cheatography.com/albelop/cheat-sheets/conventional-commits/ from: https://gist.github.com/lisawolderiksen/a7b99d94c92c6671181611be1641c733
MichaelDeBoey
changed the title
build command
MichaelDeBoey
added
examples
docs
template:express
template:architect
template:cloudflare-pages
template:cloudflare-workers
template:deno
needs-response
MichaelDeBoey
changed the title
build commandbuild command
|
@CanRau Changes to |
MichaelDeBoey
added
needs-response
|
Closing this in favor of #3595 |
MichaelDeBoey
added
duplicate
|
Sorry the PR/notification got lost, glad there's another one 👌 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into mysticatea/npm-run-all#200 using Yarn 3
Quoting it "dev": "run-p 'dev:*'", like mentioned in the linked issue fixed it for me with Yarn 3 and also tested Yarn 1.22.10 and npm 8.1.0, just to make sure.
So I figured as it shouldn't break anything why not always quote it?
Ref mysticatea/npm-run-all#200
As @machour requested that I fix the conflicts in #2033 but I felt it was to much mental overhead right now to get my head around fixing the other PR 🤯 I created a new one, renaming my branch and PR and also realized that I missed
run-scommands containing globs as well 🤦🏻♂️