Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump remix to react-router-dom@6.4.3 #4668

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Bump remix to react-router-dom@6.4.3 #4668

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8f3a88
Bump remix to react-router-dom@6.4.3
brophdawg11 Nov 22, 2022
18f2c37
add changeset
brophdawg11 Nov 22, 2022
bce3f37
Fix TS error
brophdawg11 Nov 22, 2022
a6458b2
Fix typo
brophdawg11 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/remix-react/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ function Routes() {
// need this component, we can just `renderMatches` from RemixEntry
let { clientRoutes } = useRemixEntryContext();
// fallback to the root if we don't have a match

// TODO: clientRoutes currently errors here since RR 6.4 dropped signal as a
// loader argument. We'll be adding tat bac in as part of the rendering work.
// @ts-expect-error
let element = useRoutes(clientRoutes) || (clientRoutes[0].element as any);
return element;
}
Expand Down