fix(remix-react): fix content-type on proxied action request
#4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e8e8a15 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Jan 3, 2023
| @@ -36,16 +36,18 @@ export async function fetchData( | |||
| let url = new URL(request.url); | |||
| url.searchParams.set("_data", routeId); | |||
|
|
|||
| let init: RequestInit | undefined; | |||
| let init: RequestInit = { signal: request.signal }; | |||
There was a problem hiding this comment.
We can always start with the signal now
brophdawg11
commented
Jan 3, 2023
| // paragraph of https://httpwg.org/specs/rfc9110.html#field.content-type | ||
| contentType && /\bapplication\/x-www-form-urlencoded\b/.test(contentType) | ||
| ? new URLSearchParams(await request.text()) | ||
| : await request.formData(); |
There was a problem hiding this comment.
Conditionally set URLSearchParams or FormData as the body and let Content-Type inherit automatically
mcansh
approved these changes
Jan 4, 2023
jacob-ebey
approved these changes
Jan 4, 2023
MichaelDeBoey
approved these changes
Jan 4, 2023
MichaelDeBoey
changed the title
content-type on proxied action request
brophdawg11
added a commit
that referenced
this pull request
Jan 4, 2023
This was referenced Jan 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4967