-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(remix-testing): use router.routes
so routes have ids
#5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan McAnsh <logan@mcan.sh>
🦋 Changeset detectedLatest commit: f76f243 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
brophdawg11
approved these changes
Jan 18, 2023
🤖 Hello there, We just published version Thanks! |
andrelandgraf
pushed a commit
to andrelandgraf/remix
that referenced
this pull request
Jan 22, 2023
…#5128) * fix(remix-testing): use router.routes so routes have ids Signed-off-by: Logan McAnsh <logan@mcan.sh> * test: add some tests Signed-off-by: Logan McAnsh <logan@mcan.sh> * chore: add all packages to jest projects Signed-off-by: Logan McAnsh <logan@mcan.sh> * Create mighty-beans-judge.md Signed-off-by: Logan McAnsh <logan@mcan.sh>
This was referenced Jan 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Signed-off-by: Logan McAnsh logan@mcan.sh
Closes: #
Testing Strategy: