Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: resolve route module imports back to virtual #6098

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented Apr 18, 2023

Resolves imports to the proper locations and ensure duplicate modules do not end up in the graph.

Visual explanation:
image

Closes: #

  • Docs
  • Tests

Testing Strategy:

  • Duplicated existing v1 integration test that was failing for v2.
  • Added new MDX integration tests

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: 5bfb3f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori self-assigned this Apr 18, 2023
@jacob-ebey jacob-ebey merged commit 8941a69 into dev Apr 19, 2023
@jacob-ebey jacob-ebey deleted the routes_ast_transform branch April 19, 2023 19:32
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Apr 19, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-8941a69-20230420 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants