Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(remix-dev): normalize path before testing if it is a route entry #6293

Merged
merged 2 commits into from
May 3, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented May 3, 2023

before this, entryPoints were normalized to use unix path separators (/) where file and appFile were using windows path separators (\\)

commit was done in parallels on windows 11 where i don't have gpg set up, sue me

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #5247

  • Docs
  • Tests

Testing Strategy: local testing on windows

@mcansh mcansh requested a review from pcattori May 3, 2023 15:16
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

🦋 Changeset detected

Latest commit: 3f205e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh merged commit acdd7c7 into dev May 3, 2023
@mcansh mcansh deleted the logan/unstable_dev_entries branch May 3, 2023 15:40
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@xHomu
Copy link
Contributor

xHomu commented May 17, 2023

Can confirm that new routes are now working in windows with v2 routing flag on!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.16.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants