Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(remix-node): fix NodeRequest's clone function #6512

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Conversation

jacob-ebey
Copy link
Member

@jacob-ebey jacob-ebey commented May 31, 2023

Updated tests from #5566

@tomer-yechiel

Closes: #5520

  • Docs
  • Tests

Testing Strategy:

Ensure instanceof passes as well as updating test to utilize a ReadableStream to ensure body is not being locked for clone / og consumers.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: bd6f442

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/node Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/serve Patch
@remix-run/testing Patch
@remix-run/vercel Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/react Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacob-ebey jacob-ebey marked this pull request as ready for review May 31, 2023 18:27
@MichaelDeBoey MichaelDeBoey changed the title Fix request clone fix(remix-node): fix NodeRequest's clone function May 31, 2023
@jacob-ebey jacob-ebey merged commit 7fc2d14 into dev Jun 1, 2023
@jacob-ebey jacob-ebey deleted the fix-request-clone branch June 1, 2023 20:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-70cc627-20230602 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

🤖 Hello there,

We just published version 1.17.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

🤖 Hello there,

We just published version 1.17.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants