fix(remix-server-runtime): fix false-positive resource route identification on doc requests

[brophdawg11]

This adds the corresponding logic from #6125 (closing #6106) for document requests. A resource route should be a route that exports no UI components, not just one that doesn't export a happy path UI component.

This way it's possible to do a self-contained splat route 404 page. Previously, the below would be interpreted as a resource route and just return the raw text as a response and ignore the ErrorBoundary.

// $.jsx
import { useRouteError } from "react-router-dom";

export async function loader({ request }) {
  throw new Response(`${new URL(request.url).pathname} not found`, {
    status: 404,
    statusText: "Not Found",
  });
}

export function ErrorBoundary() {
  let error = useRouteError();
  return (
    <>
      <h1>
        {error.status} {error.statusText}
      </h1>
      <p>{error.data}</p>
    </>
  );
}

[changeset-bot]

🦋 Changeset detected

Latest commit: 96245e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/server-runtime	Patch
@remix-run/cloudflare	Patch
@remix-run/deno	Patch
@remix-run/dev	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/serve	Patch
@remix-run/testing	Patch
create-remix	Patch
remix	Patch
@remix-run/css-bundle	Patch
@remix-run/eslint-config	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ryanflorence]

What if the loader doesn't throw though?

[brophdawg11]

If an ErrorBoundary is specified and a default export is not, then it defaults the route's happy path UI component to Outlet - just like <Route path="something"> would - https://github.com/remix-run/remix/blob/main/packages/remix-react/components.tsx#L132

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-65fdbcd-20230815 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!