Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix resource routes being loaded through route.lazy #7498

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Fix resource routes being loaded through route.lazy #7498

merged 5 commits into from
Sep 21, 2023

Conversation

brophdawg11
Copy link
Contributor

Resource routes are compiled with a default export of {}, so we need to ignore those empty objects when assigning Component via route.lazy

Closes #7497

@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f04cd13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Sep 20, 2023 that may be closed by this pull request
Element type invalid warning using useFetcher with a Form action #7497
Closed
1 task
brophdawg11
brophdawg11 commented Sep 21, 2023
View reviewed changes
packages/remix-react/routes.tsx
handle: routeModule.handle,
links: routeModule.links,
meta: routeModule.meta,
shouldRevalidate: routeModule.shouldRevalidate,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually re-exporting the fields here makes TS happier since it doesn't have to worry about the IndexRoute/NonIndexRoute stuff

@brophdawg11 brophdawg11 merged commit 6640c5a into dev Sep 21, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/route-lazy-resource-route branch September 21, 2023 15:45
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Sep 21, 2023
@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Sep 21, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Sep 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed feat:routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Element type invalid warning using useFetcher with a Form action
1 participant
@brophdawg11