Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update cookie #8375

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

tomer-yechiel
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

Copy link

changeset-bot bot commented Dec 24, 2023

🦋 Changeset detected

Latest commit: 1f19b87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/server-runtime Minor
@remix-run/cloudflare Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/architect Minor
@remix-run/express Minor
@remix-run/serve Minor
@remix-run/testing Minor
create-remix Minor
remix Minor
@remix-run/css-bundle Minor
@remix-run/eslint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

Thanks! Would you mind adding a Changeset? I tried adding the following but can't push to your remote branch:

.changeset/upgrade-cookie-package.md

---
"@remix-run/server-runtime": minor
---

Updated `cookie` dependency to [`0.6.0`](https://github.com/jshttp/cookie/blob/master/HISTORY.md#060--2023-11-06) to inherit support for the [`Partitioned`](https://developer.mozilla.org/en-US/docs/Web/Privacy/Partitioned_cookies) attribute

@brophdawg11 brophdawg11 added feat:cookies dependencies Pull requests that update a dependency file labels Jan 2, 2024
@tomer-yechiel
Copy link
Contributor Author

Thanks! Would you mind adding a Changeset? I tried adding the following but can't push to your remote branch:

.changeset/upgrade-cookie-package.md

---
"@remix-run/server-runtime": minor
---

Updated `cookie` dependency to [`0.6.0`](https://github.com/jshttp/cookie/blob/master/HISTORY.md#060--2023-11-06) to inherit support for the [`Partitioned`](https://developer.mozilla.org/en-US/docs/Web/Privacy/Partitioned_cookies) attribute

i tried, to but it automatically create a major version change.
i need to create it manually?

@tomer-yechiel tomer-yechiel changed the base branch from dev to main January 2, 2024 17:59
@tomer-yechiel tomer-yechiel changed the base branch from main to dev January 2, 2024 17:59
@tomer-yechiel tomer-yechiel force-pushed the update_cookies_package branch from c42ad16 to 0130125 Compare January 2, 2024 18:08
@brophdawg11
Copy link
Contributor

Oh, no you just need to press Enter without selecting any packages for a major bump, and then it will prompt you for which packages need a minor bump:

Screenshot 2024-01-03 at 12 10 38 PM

But the manually added file works great too!

@brophdawg11 brophdawg11 merged commit cc8d695 into remix-run:dev Jan 3, 2024
5 checks passed
@tomer-yechiel tomer-yechiel deleted the update_cookies_package branch January 3, 2024 17:16
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 2.5.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CLA Signed dependencies Pull requests that update a dependency file feat:cookies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants