Loop: Updated to use a single Sequence to fix video gaps #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks a lot! 🥳 🙌 Sorry for the inaccurate issue description leading you the wrong way. We'll definitely try to learn from that to improve in the future! Even more impressive that you hung in there! ✊ Also unexpectedly, this led to the Loop component being displayed in a weird way in the timeline - fixed that up now as well! |
JonnyBurger
approved these changes
May 16, 2023
|
No worries @JonnyBurger thanks for the help along the way. Hopefully I can contribute more in the future. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took me a few hours to understand what was going on. To be fair I had not looked at the source code for Remotion before. As noted in #2207 (comment) the issue is that
Sequenceunmounts it's children when it isn't in frame. Looping using a collection ofSequencecomponents therefore has this gap issue because of this unmounting and remounting of the underlyingVideocomponent.This solution uses a bit of code from Discord modified such that it will stop after the maximum frame has been reached.
Fixes #2207
/claim #2207