Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Lean: fix translation of try-catch #1074

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ineol
Copy link
Collaborator

@ineol ineol commented Feb 25, 2025

I'm not very happy with the fix though, if someone has a better one feel free to replace this PR.

@ineol ineol added the Lean Issues with Sail to Lean translation label Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

Test Results

   13 files     29 suites   0s ⏱️
  844 tests   844 ✅ 0 💤 0 ❌
3 532 runs  3 532 ✅ 0 💤 0 ❌

Results for commit f4554f4.

♻️ This comment has been updated with latest results.

@ineol ineol force-pushed the lean-fix-try-catch branch 2 times, most recently from b943dcf to 6d9fce0 Compare February 27, 2025 19:25
@ineol ineol changed the title Lean: fix try-catch in RISC-V main function Lean: fix translation of try-catch Feb 28, 2025
This fixes the translation of the main function of the RISC-V model.
@ineol ineol force-pushed the lean-fix-try-catch branch from 6d9fce0 to f4554f4 Compare February 28, 2025 09:36
Copy link
Collaborator

@javra javra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacam bacam merged commit 5bdbdb2 into rems-project:sail2 Feb 28, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Lean Issues with Sail to Lean translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants