Lean: Change loops to use native lean loops #1086
Merged
+542
−609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 13 files 29 suites 0s ⏱️ Results for commit d793b64. ♻️ This comment has been updated with latest results. |
ineol
force-pushed
the
lean/early_return_to_throw
branch
from
9d7a5e7 to
1485f95
Compare
lfrenot
changed the title
|
Do you also plan on using |
TODO: handle while and remove useless loop_ functions
lfrenot
force-pushed
the
lean/early_return_to_throw
branch
from
1485f95 to
255a573
Compare
test/lean/loop.expected.lean
Outdated
| @@ -128,17 +128,22 @@ def concat_str_dec (str : String) (x : Int) : String := | |||
| (HAppend.hAppend str (Int.repr x)) | |||
|
|
|||
| /-- Type quantifiers: n : Nat, m : Nat, 0 ≤ m, 0 ≤ n -/ | |||
| def foreach_loop (m : Nat) (n : Nat) : Nat := | |||
| def foreach_loop (m : Nat) (n : Nat) : SailM Nat := do | |||
There was a problem hiding this comment.
Why does this PR introduce effects here?
There was a problem hiding this comment.
This was a mistake, it was fixed in the next commit
There was a problem hiding this comment.
I still see effects here.
tobiasgrosser
approved these changes
Feb 28, 2025
test/lean/loop.expected.lean
Outdated
| @@ -128,17 +128,22 @@ def concat_str_dec (str : String) (x : Int) : String := | |||
| (HAppend.hAppend str (Int.repr x)) | |||
|
|
|||
| /-- Type quantifiers: n : Nat, m : Nat, 0 ≤ m, 0 ≤ n -/ | |||
| def foreach_loop (m : Nat) (n : Nat) : Nat := | |||
| def foreach_loop (m : Nat) (n : Nat) : SailM Nat := do | |||
There was a problem hiding this comment.
I still see effects here.
|
I haven't updated the tests yet because there are some issues that need #1089 to be merged first |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the issues with #1071
To be merged after #1084