refactor: remove deprecated util.error #699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with console.error Replace util.log with console.log to be consistent with _log
|
I can't mange to reproduce the failed build. All the tests pass for me using Node versions: (4.2.1), (0.12.7) and (0.10.29). I have been using a different npm version (3.3.8), but I don't see how that could cause this. |
|
I think I commited this next fix minutes after you merged the original PR. Should I update my fork and make a new PR? |
|
I think these changes actually got merged in a long time ago! Sorry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with console.error
Replace util.log with console.log to be consistent with _log