Skip to content

Commit

Permalink
feat(versioning): apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Michael Kriese <michael.kriese@gmx.de>
  • Loading branch information
ivankatliarchuk and viceice authored Jan 17, 2025
1 parent d4dd226 commit 6409d5d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/modules/versioning/aws-eks-addon/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class AwsEKSAddonVersioningApi extends GenericVersioningApi {
if (!suffix) {
return null;
}
const release = [Number(major), Number(minor), Number(patch)];
const release = [parseInt((major, 19), parseInt(minor, 10), parseInt(patch, 10)];

Check failure on line 31 in lib/modules/versioning/aws-eks-addon/index.ts

View workflow job for this annotation

GitHub Actions / lint-other

',' expected.

Check failure on line 31 in lib/modules/versioning/aws-eks-addon/index.ts

View workflow job for this annotation

GitHub Actions / lint-eslint

Parsing error: ',' expected.

Check failure on line 31 in lib/modules/versioning/aws-eks-addon/index.ts

View workflow job for this annotation

GitHub Actions / build

',' expected.

Check failure on line 31 in lib/modules/versioning/aws-eks-addon/index.ts

View workflow job for this annotation

GitHub Actions / build-docs

',' expected.
return { release, suffix };
}

Expand Down
2 changes: 1 addition & 1 deletion lib/modules/versioning/aws-eks-addon/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ AWS versioning syntax is used for EKS Addon updates.

It is based off [Semantic Versioning 2.0](https://semver.org) but with a subset of addon `build metadata` syntax.

At the moment every ESK Addon that matches the regex `^[vV]?(\d+(?:\.\d+)*)(-eksbuild\.\d+)?$` is considered a valid "release".
At the moment every ESK Addon that matches the regex `^[v]?(\d+(?:\.\d+)*)(-eksbuild\.\d+)?$` is considered a valid "release".

**Key Points about EKS Addon Versioning**

Expand Down

0 comments on commit 6409d5d

Please # to comment.